Skip to content

Commit

Permalink
srds: remove a redundant if block
Browse files Browse the repository at this point in the history
Merge artifact - we're checking this condition above, so this block
should never be executed. However, the logic was just tightened in
PR #36702 and isn't reflected in this block, so removing it.

Signed-off-by: Eugene Chan <[email protected]>
  • Loading branch information
pianiststickman committed Oct 31, 2024
1 parent 841d78c commit 6c265bc
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions source/common/router/scoped_rds.cc
Original file line number Diff line number Diff line change
Expand Up @@ -312,11 +312,6 @@ absl::StatusOr<bool> ScopedRdsConfigSubscription::addOrUpdateScopes(
if (scoped_route_config.route_configuration_name().empty()) {
return absl::InvalidArgumentError("route_configuration_name is empty.");
}
if (const auto& scope_info_iter = scoped_route_map_.find(scope_name);
scope_info_iter != scoped_route_map_.end() &&
scope_info_iter->second->configHash() == MessageUtil::hash(scoped_route_config)) {
continue;
}
rds.set_route_config_name(scoped_route_config.route_configuration_name());
std::unique_ptr<RdsRouteConfigProviderHelper> rds_config_provider_helper;
if (scoped_route_config.on_demand() == false) {
Expand Down

0 comments on commit 6c265bc

Please sign in to comment.