Minor nits.

Signed-off-by: Kevin Baichoo <[email protected]>
envoyproxy · Feb 2, 2021 · 5d3838b · 5d3838b
1 parent d3a50a5
commit 5d3838b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/source/common/common/utility.cc b/source/common/common/utility.cc
@@ -457,7 +457,7 @@ std::string StringUtil::escape(const std::string& source) {
   return ret;
 }
 
-// TODO(kbaichoo): If needed, add support for escaping < and chars >= 127.
+// TODO(kbaichoo): If needed, add support for escaping chars < 32 and >= 127.
 void StringUtil::escapeToOstream(std::ostream& os, absl::string_view view) {
   for (const char c : view) {
     switch (c) {

diff --git a/source/common/http/http1/codec_impl.cc b/source/common/http/http1/codec_impl.cc
@@ -911,7 +911,9 @@ void ServerConnectionImpl::dumpAdditionalState(std::ostream& os, int indent_leve
                        active_request_.has_value() &&
                                !active_request_.value().request_url_.getStringView().empty()
                            ? active_request_.value().request_url_.getStringView()
-                           : "null\n");
+                           : "null");
+  os << '\n';
+
   // Dump header map, it may be null if it was moved to the request, and
   // request_url.
   if (absl::holds_alternative<RequestHeaderMapPtr>(headers_or_trailers_)) {