Skip to content

Commit

Permalink
Trying to fix test failures on Windows
Browse files Browse the repository at this point in the history
Signed-off-by: Dmitri Dolguikh <[email protected]>
  • Loading branch information
Dmitri Dolguikh committed Aug 17, 2021
1 parent de40b51 commit 58837b7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion source/common/config/xds_mux/grpc_mux_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ GrpcMuxImpl<S, F, RQ, RS>::GrpcMuxImpl(std::unique_ptr<F> subscription_state_fac
}

template <class S, class F, class RQ, class RS> GrpcMuxImpl<S, F, RQ, RS>::~GrpcMuxImpl() {
ENVOY_LOG(info, "in ~GrpcMuxImpl() !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
std::cout << "in ~GrpcMuxImpl() !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
<< "\n";
AllMuxes::get().erase(this);
}

Expand Down
2 changes: 1 addition & 1 deletion source/common/config/xds_mux/grpc_mux_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class GrpcMuxImpl : public GrpcStreamCallbacks<RS>,
const Protobuf::MethodDescriptor& service_method, Random::RandomGenerator& random,
Stats::Scope& scope, const RateLimitSettings& rate_limit_settings);

~GrpcMuxImpl() override;
virtual ~GrpcMuxImpl();

// Causes all GrpcMuxImpl objects to stop sending any messages on `grpc_stream_` to fix a crash
// on Envoy shutdown due to dangling pointers. This may not be the ideal fix; it is probably
Expand Down

0 comments on commit 58837b7

Please sign in to comment.