Skip to content

Commit

Permalink
addressing comments
Browse files Browse the repository at this point in the history
Signed-off-by: Yanjun Xiang <[email protected]>
  • Loading branch information
yanjunxiang-google committed Jul 14, 2021
1 parent 9284f74 commit 4eca309
Show file tree
Hide file tree
Showing 12 changed files with 60 additions and 60 deletions.
10 changes: 5 additions & 5 deletions api/envoy/config/bootstrap/v3/bootstrap.proto
Original file line number Diff line number Diff line change
Expand Up @@ -266,16 +266,16 @@ message Bootstrap {
core.v3.DnsResolutionConfig dns_resolution_config = 30;

// DNS resolver type configuration extension. This extension can be used to configure c-ares, apple,
// or any other DNS resolver types and the related parameters. When c-ares DNS is configured,
// or any other DNS resolver types and the related parameters.
// For example, an object of :ref:`envoy_v3_api_msg_config.core.v3.DnsResolutionConfig`
// can be packed into this *typed_dns_resolver_config*. This configuration will replace the
// :ref:'dns_resolution_config <envoy_v3_api_field_config.bootstrap.v3.Bootstrap.dns_resolution_config>'
// will be enclosed in this *typed_dns_resolver_config*.
// This configuration will replace the *dns_resolution_config* configuration eventually.
// configuration eventually.
// TODO(yanjunxiang): Investigate the deprecation plan for *dns_resolution_config*.
// During the transition period when both *dns_resolution_config* and *typed_dns_resolver_config* exists,
// this configuration is optional.
// When *typed_dns_resolver_config* is in place, Envoy will use it and ignore *dns_resolution_config*.
// When *typed_dns_resolver_config* is missing, the default behavior is in place. Envoy will either use
// c-ares DNS library or apple DNS library based on the compiling flag.
// When *typed_dns_resolver_config* is missing, the default behavior is in place.
// [#not-implemented-hide:]
core.v3.TypedExtensionConfig typed_dns_resolver_config = 31;

Expand Down
10 changes: 5 additions & 5 deletions api/envoy/config/bootstrap/v4alpha/bootstrap.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions api/envoy/config/cluster/v3/cluster.proto
Original file line number Diff line number Diff line change
Expand Up @@ -880,16 +880,16 @@ message Cluster {
core.v3.DnsResolutionConfig dns_resolution_config = 53;

// DNS resolver type configuration extension. This extension can be used to configure c-ares, apple,
// or any other DNS resolver types and the related parameters. When c-ares DNS is configured,
// or any other DNS resolver types and the related parameters.
// For example, an object of :ref:`envoy_v3_api_msg_config.core.v3.DnsResolutionConfig`
// can be packed into this *typed_dns_resolver_config*. This configuration will replace the
// :ref:'dns_resolution_config <envoy_v3_api_field_config.cluster.v3.Cluster.dns_resolution_config>'
// will be enclosed in this *typed_dns_resolver_config*.
// This configuration will replace the *dns_resolution_config* configuration eventually.
// configuration eventually.
// TODO(yanjunxiang): Investigate the deprecation plan for *dns_resolution_config*.
// During the transition period when both *dns_resolution_config* and *typed_dns_resolver_config* exists,
// this configuration is optional.
// When *typed_dns_resolver_config* is in place, Envoy will use it and ignore *dns_resolution_config*.
// When *typed_dns_resolver_config* is missing, the default behavior is in place. Envoy will either use
// c-ares DNS library or apple DNS library based on the compiling flag.
// When *typed_dns_resolver_config* is missing, the default behavior is in place.
// [#not-implemented-hide:]
core.v3.TypedExtensionConfig typed_dns_resolver_config = 55;

Expand Down
10 changes: 5 additions & 5 deletions api/envoy/config/cluster/v4alpha/cluster.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -115,16 +115,16 @@ message DnsCacheConfig {
config.core.v3.DnsResolutionConfig dns_resolution_config = 9;

// DNS resolver type configuration extension. This extension can be used to configure c-ares, apple,
// or any other DNS resolver types and the related parameters. When c-ares DNS is configured,
// or any other DNS resolver types and the related parameters.
// For example, an object of :ref:`envoy_v3_api_msg_config.core.v3.DnsResolutionConfig`
// can be packed into this *typed_dns_resolver_config*. This configuration will replace the
// :ref:'dns_resolution_config <envoy_v3_api_field_extensions.common.dynamic_forward_proxy.v3.DnsCacheConfig.dns_resolution_config>'
// will be enclosed in this *typed_dns_resolver_config*.
// This configuration will replace the *dns_resolution_config* configuration eventually.
// configuration eventually.
// TODO(yanjunxiang): Investigate the deprecation plan for *dns_resolution_config*.
// During the transition period when both *dns_resolution_config* and *typed_dns_resolver_config* exists,
// this configuration is optional.
// When *typed_dns_resolver_config* is in place, Envoy will use it and ignore *dns_resolution_config*.
// When *typed_dns_resolver_config* is missing, the default behavior is in place. Envoy will either use
// c-ares DNS library or apple DNS library based on the compiling flag.
// When *typed_dns_resolver_config* is missing, the default behavior is in place.
// [#not-implemented-hide:]
config.core.v3.TypedExtensionConfig typed_dns_resolver_config = 12;

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions generated_api_shadow/envoy/config/bootstrap/v3/bootstrap.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions generated_api_shadow/envoy/config/cluster/v3/cluster.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions generated_api_shadow/envoy/config/cluster/v4alpha/cluster.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4eca309

Please sign in to comment.