http1: remove exceptions from H/1 codec (#11778)

Commit Message: Remove all throw statements from H/1 codec This change removed all uses of C++ exceptions from H/1 codec. I modeled the flow after Yan's H/2 work (#11575). Codec status are set in uniform helper methods. This is the only change from the previous PR (#11101), besides merging newer exceptions. This change replaces all throw statements with a return of corresponding error Status and adds plumbing to return the status to codec callers. The dispatch() method returns the encountered error to the caller, which will be handled accordingly. The calls to the RequestEncoder::encodeHeaders() NOT called from dispatch() method will RELEASE_ASSERT if an error code is returned. This does not alter the existing behavior of abnormally terminating the process, just the method of termination: RELEASE_ASSERT vs uncaught exception. Risk Level: High (Codec changes) Signed-off-by: Asra Ali <[email protected]>
envoyproxy · Aug 10, 2020 · 2187f10 · 2187f10
1 parent bb3571a
commit 2187f10
Show file tree

Hide file tree

Showing 5 changed files with 250 additions and 134 deletions.
diff --git a/source/common/http/http1/BUILD b/source/common/http/http1/BUILD
@@ -55,7 +55,7 @@ envoy_cc_library(
     srcs = ["codec_impl.cc"],
     hdrs = ["codec_impl.h"],
     external_deps = ["http_parser"],
-    deps = CODEC_LIB_DEPS,
+    deps = CODEC_LIB_DEPS + ["//source/common/common:cleanup_lib"],
 )
 
 envoy_cc_library(