python: envoy_requests depend on a specific version of protobuf #1504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR introduces a requirement that consumers of envoy-requests must have
protobuf==3.17
to prevent crashes. I've been able to consistently reproduce crashes in Python applications on the main branch by://library/python:envoy_requests_whl
onmain
protobuf==3.14
(previous version before envoy bump) orprotobuf==3.16
(current version after envoy bump)protobuf==3.14
protobuf==3.16
This succeeds when running
protobuf==3.17
, however, hence the version I've chosen to require.I've narrowed this problem down to an indirect import of
google.protobuf.pyext._message
. Importing that module calls InitProto2MessageModule which does a lot of initialization, but I'm not sure which part causes the problem. I'm still struggling to understand how this all happens, so if anyone has any ideas I'd love to hear them!Risk Level: Low
Testing: Documented above
Docs Changes: N/A
Release Notes: N/A