Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BindConfig: make upstream and downstream bind config consistent. #583

Merged
merged 1 commit into from
Mar 27, 2018
Merged

BindConfig: make upstream and downstream bind config consistent. #583

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions envoy/api/v2/core/address.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,14 @@ message BindConfig {
SocketAddress source_address = 1
[(validate.rules).message.required = true, (gogoproto.nullable) = false];

// [#not-implemented-hide:] Whether to set the IP_FREEBIND option when creating the socket. If
// set, allows the source_address specified to be an address that is not configured on the system
// running Envoy. Defaults to false.
bool freebind = 2;
// [#not-implemented-hide:] Whether to set the *IP_FREEBIND* option when
// creating the socket. When this flag is set to true, allows the
// :ref:`source_address <envoy_api_field_UpstreamBindConfig.source_address>`
// to be an IP address that is not configured on the system running Envoy.
// When this flag is set to false, the option *IP_FREEBIND* is disabled on the
// socket. When this flag is not set (default), the socket is not modified,
// i.e. the option is neither enabled nor disabled.
google.protobuf.BoolValue freebind = 2;
}

// Addresses specify either a logical or physical address and port, which are
Expand Down
12 changes: 6 additions & 6 deletions envoy/api/v2/lds.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,11 @@ message Listener {
// is neither set nor reset.
google.protobuf.BoolValue transparent = 10;

// [#not-implemented-hide:] Whether the listener should set the IP_FREEBIND socket option. When
// this flag is set to true, listeners can be bound to an IP address that is not configured on
// the system running Envoy.
// When this flag is set to false, the option IP_FREEBIND is disabled on the socket.
// When this flag is not set (default), the socket is not modified, i.e. the option is neither
// enabled nor disabled.
// [#not-implemented-hide:] Whether the listener should set the *IP_FREEBIND*
// socket option. When this flag is set to true, listeners can be bound to an
// IP address that is not configured on the system running Envoy. When this
// flag is set to false, the option *IP_FREEBIND* is disabled on the socket.
// When this flag is not set (default), the socket is not modified, i.e. the
// option is neither enabled nor disabled.
google.protobuf.BoolValue freebind = 11;
}