Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add cluster warming information #541

Merged
merged 3 commits into from
Mar 14, 2018
Merged

docs: add cluster warming information #541

merged 3 commits into from
Mar 14, 2018

Conversation

mattklein123
Copy link
Member

Signed-off-by: Matt Klein [email protected]

htuch
htuch previously approved these changes Mar 13, 2018
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, will leave it for you to merge when the Envoy-side PR is merged.

---------------

When clusters are initialized both at server boot as well as via CDS, they are "warmed." This means
that clusters do not become available until the following operations have taken place.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not immediately clear what availability implies.. Does cluster unavailability imply that:

  • routes that reference the cluster fail validate_clusters check, and
  • listeners that reference the cluster remain in the warming state?

@mattklein123
Copy link
Member Author

@kyessenov updated. Better?

Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This makes it clear what availability means for clusters.

@mattklein123 mattklein123 merged commit 78dab2e into master Mar 14, 2018
@mattklein123 mattklein123 deleted the warming_docs branch March 14, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants