cds: update cluster name restrictions in Cluster. #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to envoyproxy/envoy#1806 and envoyproxy/envoy#1871. Signed-off-by: Harvey Tuch <[email protected]>
mattklein123
approved these changes
Oct 30, 2017
| @@ -63,8 +63,7 @@ message CircuitBreakers { | |||
|
|
|||
| message Cluster { | |||
| // Supplies the name of the cluster which must be unique across all clusters. | |||
| // The cluster name is used when emitting statistics. The cluster name can be | |||
| // at most 60 characters long, and must not contain :. | |||
| // Any : in the cluster name will be converted to _ when emitting statistics. | |||
There was a problem hiding this comment.
FWIW this is the kind of place in which we would cross link to the CLI option. Might be worth putting a doc TODO in here.
Signed-off-by: Harvey Tuch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to envoyproxy/envoy#1806 and
envoyproxy/envoy#1871.
Signed-off-by: Harvey Tuch [email protected]