extproc: decouple router package from api paths #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignasi Barrera <[email protected]>
Signed-off-by: Takeshi Yoneda <[email protected]>
mathetake
approved these changes
Feb 18, 2025
daixiang0
pushed a commit
to daixiang0/ai-gateway
that referenced
this pull request
Feb 19, 2025
**Commit Message** extproc: decouple router package from api paths This is a follow-up change to decouple the router package from the API paths. Now that we have specialized processors per API path it does not make sense for the router package to have path-related logic. Now each processor is responsible for instantiating the right body parser for the path they're processing. **Related Issues/PRs (if applicable)** Follow-up for envoyproxy#325 and envoyproxy#334 **Special notes for reviewers (if applicable)** N/A --------- Signed-off-by: Ignasi Barrera <[email protected]> Co-authored-by: Takeshi Yoneda <[email protected]> Signed-off-by: Loong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message
extproc: decouple router package from api paths
This is a follow-up change to decouple the router package from the API paths. Now that we have specialized processors per API path it does not make sense for the router package to have path-related logic.
Now each processor is responsible for instantiating the right body parser for the path they're processing.
Related Issues/PRs (if applicable)
Follow-up for #325 and #334
Special notes for reviewers (if applicable)
N/A