Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always download CI tools #320

Closed
daixiang0 opened this issue Feb 11, 2025 · 0 comments · Fixed by #321
Closed

Always download CI tools #320

daixiang0 opened this issue Feb 11, 2025 · 0 comments · Fixed by #321
Labels
bug Something isn't working

Comments

@daixiang0
Copy link
Member

daixiang0 commented Feb 11, 2025 •
edited
Loading

Description:

Download some tools in every run:

root:[ai-gateway]$ make precommit
tidy => .
spell => ./...
Downloading sigs.k8s.io/controller-tools/cmd/[email protected]   <===
apigen => ./api/v1alpha1/...
Downloading github.com/elastic/[email protected]
2025-02-11T14:43:18.390+0800    INFO    crd-ref-docs    Loading configuration   {"path": "site/crd-ref-docs/config-core.yaml"}
2025-02-11T14:43:18.391+0800    INFO    crd-ref-docs    Processing source directory     {"directory": "api/v1alpha1", "depth": 20}
2025-02-11T14:43:18.968+0800    INFO    crd-ref-docs    Rendering output        {"path": "site/docs/api/api.mdx"}
2025-02-11T14:43:18.974+0800    INFO    crd-ref-docs    CRD reference documentation generated
2025-02-11T14:43:18.974+0800    INFO    crd-ref-docs    Execution time: 583.120301ms
Downloading github.com/daixiang0/[email protected]
Downloading mvdan.cc/[email protected]
format => *.go
./internal/controller/sink_test.go
gci => *.go
Downloading github.com/golangci/golangci-lint/cmd/[email protected]  <===
lint => ./...
Downloading github.com/editorconfig-checker/editorconfig-checker/v3/cmd/[email protected]
running editorconfig-checker
yamllint => ./...
helm-lint => ../manifests/charts/ai-gateway-helm
==> Linting ./manifests/charts/ai-gateway-helm

1 chart(s) linted, 0 chart(s) failed
@daixiang0 daixiang0 added the bug Something isn't working label Feb 11, 2025
@daixiang0 daixiang0 mentioned this issue Feb 11, 2025
Merged
mathetake added a commit that referenced this issue Feb 11, 2025
@daixiang0 @mathetake
chore: fix always reinstall (#321)
0c851f6 
**Commit Message**

Previously, all Go-installed tools are always installed because of the
trailing spaces. This fixes Makefile.tools.mk so that we can properly
cache the tools.

**Related Issues/PRs (if applicable)**

Fixes #320

---------

Signed-off-by: Loong <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
daixiang0 added a commit to daixiang0/ai-gateway that referenced this issue Feb 12, 2025
@daixiang0 @mathetake
chore: fix always reinstall (envoyproxy#321)
8906809 
**Commit Message**

Previously, all Go-installed tools are always installed because of the
trailing spaces. This fixes Makefile.tools.mk so that we can properly
cache the tools.

**Related Issues/PRs (if applicable)**

Fixes envoyproxy#320

---------

Signed-off-by: Loong <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
daixiang0 added a commit to daixiang0/ai-gateway that referenced this issue Feb 12, 2025
@daixiang0 @mathetake
chore: fix always reinstall (envoyproxy#321)
9c79e5d 
**Commit Message**

Previously, all Go-installed tools are always installed because of the
trailing spaces. This fixes Makefile.tools.mk so that we can properly
cache the tools.

**Related Issues/PRs (if applicable)**

Fixes envoyproxy#320

---------

Signed-off-by: Loong <[email protected]>
Co-authored-by: Takeshi Yoneda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix always reinstall daixiang0/ai-gateway
1 participant
@daixiang0