Reshare e2e test

RELEASE_CHECKLIST.md

@@ -5,6 +5,9 @@ tagged as the final release.
 
 ## Pre-Prep
 - [ ] Inform relevant parties that you're preparing a release (e.g, by posting on Discord)
+- [ ] Manually run e2e reshare test 
+(first compile node with features=reshare-test and then run 
+```cargo test --release --features=reshare-test -- --test test_reshare_e2e```)
 - [ ] Create a release branch, e.g., for release candidate `1`: `release/vX.Y.Z-rc.1`.
 
 ## Prep the Runtime and Node

crates/threshold-signature-server/Cargo.toml

@@ -113,4 +113,5 @@ alice       =[]
 bob         =[]
 # Enable this feature to run the integration tests for the wasm API of entropy-protocol
 # This requires the entropy-protocol node-js module to be built and so is not run by default
-wasm_test=[]
+wasm_test   =[]
+reshare-test=[]

crates/threshold-signature-server/src/validator/tests.rs

@@ -239,6 +239,64 @@ async fn test_reshare_basic() {
     clean_tests();
 }
 
+#[cfg(feature = "reshare-test")]
+#[tokio::test]
+#[serial]
+async fn test_reshare_e2e() {
+    initialize_test_logger().await;
+    clean_tests();
+
+    let (_validator_ips, _validator_ids) =
+        spawn_testing_validators(crate::helpers::tests::ChainSpecType::IntegrationJumpStarted)
+            .await;
+
+    let force_authoring = true;
+    let context =
+        test_node_process_testing_state(ChainSpecType::IntegrationJumpStarted, force_authoring)
+            .await;
+    let api = get_api(&context[0].ws_url).await.unwrap();
+    let rpc = get_rpc(&context[0].ws_url).await.unwrap();
+    let client = reqwest::Client::new();
+
+    // Get current signers
+    let signer_query = entropy::storage().staking_extension().signers();
+    let signer_stash_accounts = query_chain(&api, &rpc, signer_query, None).await.unwrap().unwrap();
+    let old_signer_ids: HashSet<[u8; 32]> =
+        HashSet::from_iter(signer_stash_accounts.clone().into_iter().map(|id| id.0));
+    let key_share_before = unsafe_get(&client, hex::encode(NETWORK_PARENT_KEY), 3002).await;
+
+    let mut i = 0;
+    // Wait up to 2min for reshare to complete: check once every second if we have a new set of signers.
+    let _ = loop {
+        let new_signer_ids: HashSet<[u8; 32]> = {
+            let signer_query = entropy::storage().staking_extension().signers();
+            let signer_ids = query_chain(&api, &rpc, signer_query, None).await.unwrap().unwrap();
+            HashSet::from_iter(signer_ids.into_iter().map(|id| id.0))
+        };
+        if new_signer_ids != old_signer_ids {
+            break Ok(new_signer_ids);
+        }
+        if i > 240 {
+            break Err("Timed out waiting for reshare");
+        }
+        i += 1;
+        tokio::time::sleep(std::time::Duration::from_secs(1)).await;
+    }
+    .unwrap();
+
+    // wait for rotate keyshare
+    tokio::time::sleep(std::time::Duration::from_secs(10)).await;
+
+    let key_share_after = unsafe_get(&client, hex::encode(NETWORK_PARENT_KEY), 3002).await;
+    assert_ne!(key_share_before, key_share_after);
+
+    // wait for rotate keyshare 2
+    tokio::time::sleep(std::time::Duration::from_secs(80)).await;
+
+    let key_share_after_2 = unsafe_get(&client, hex::encode(NETWORK_PARENT_KEY), 3002).await;
+    assert_ne!(key_share_after, key_share_after_2);
+}
+
 #[tokio::test]
 #[serial]
 async fn test_reshare_none_called() {

node/cli/Cargo.toml

@@ -122,3 +122,4 @@ try-runtime=["entropy-runtime/try-runtime", "try-runtime-cli/try-runtime"]
 # Enables real PCK certificate chain verification - which means TSS nodes must be runnning on TDX
 # hardware
 production=["entropy-runtime/production"]
+reshare-test=["entropy-runtime/reshare-test"]

node/cli/src/chain_spec/integration_tests.rs

@@ -151,7 +151,9 @@ pub fn integration_tests_genesis_config(
         "staking": StakingConfig {
             validator_count: initial_authorities.len() as u32,
             minimum_validator_count: 0,
-            invulnerables: vec![],
+            invulnerables: initial_authorities
+            .iter()
+            .map(|x| {x.0.clone()}).collect::<Vec<_>>(),
             slash_reward_fraction: Perbill::from_percent(10),
             stakers,
             ..Default::default()

runtime/Cargo.toml

@@ -275,4 +275,6 @@ try-runtime=[
 ]
 # Enables real PCK certificate chain verification - which means TSS nodes must be runnning on TDX
 # hardware
-production=["pallet-attestation/production"]
+production  =["pallet-attestation/production"]
+# Sets a shorter session duration for the entropy-tss test_reshare_e2e
+reshare-test=[]

runtime/src/constants.rs

@@ -78,7 +78,10 @@ pub mod time {
 
     // NOTE: Currently it is not possible to change the epoch duration after the chain has started.
     //       Attempting to do so will brick block production.
+    #[cfg(not(feature = "reshare-test"))]
     pub const EPOCH_DURATION_IN_BLOCKS: BlockNumber = 4 * HOURS;
+    #[cfg(feature = "reshare-test")]
+    pub const EPOCH_DURATION_IN_BLOCKS: BlockNumber = 15 / (SECS_PER_BLOCK as BlockNumber);
     pub const EPOCH_DURATION_IN_SLOTS: u64 = {
         const SLOT_FILL_RATE: f64 = MILLISECS_PER_BLOCK as f64 / SLOT_DURATION as f64;