Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve masking fn #249

Merged
merged 1 commit into from
Oct 3, 2024
Merged

improve masking fn #249

merged 1 commit into from
Oct 3, 2024

Conversation

mixmix
Copy link
Contributor

@mixmix mixmix commented Oct 3, 2024

test and patch masking

@mixmix mixmix requested a review from frankiebee October 3, 2024 00:17
@mixmix
Copy link
Contributor Author

mixmix commented Oct 3, 2024

Here's how the testing ran with the old masking function btw:

expected: |-
  { nested: { seed: '*******', secretKey: '***', publicKey: 'data:application/UI8A;base64,BAUG', arr: [ 'a', 'b', 'c' ], obj: { 0: 17, 1: 23 } } }
actual: |-
  { nested: { seed: '*******', secretKey: 'base64:AQID', publicKey: 'base64:BAUG', arr: 'base64:AAAA', obj: 'base64:ERc=' } }

TL;DR - it did not mask ... and it converted some objects/arrays into strings...

@frankiebee frankiebee merged commit 5865243 into dev Oct 3, 2024
2 checks passed
@frankiebee frankiebee deleted the mixmix/fix-masking branch October 3, 2024 21:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants