get all config.get* methods fail safely #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rh0delta
approved these changes
Sep 19, 2024
mixmix
commented
Sep 22, 2024
| if (err.code !== 'ENOENT') throw err | ||
|
|
||
| const newConfig = migrateData(allMigrations, {}) | ||
| mkdirp.sync(dirname(configPath)) |
There was a problem hiding this comment.
caught a bug too!
YO we are gonna need to write some testing runsheets - the "fresh install" is a test-case we are missing a lot
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a nice error-handler for
getSyncbut not forget!Consolidated!