[NayNay] Transfer updates + unit testing #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mixmix
reviewed
Jul 1, 2024
mixmix
reviewed
Jul 1, 2024
mixmix
reviewed
Jul 1, 2024
mixmix
reviewed
Jul 1, 2024
mixmix
reviewed
Jul 1, 2024
mixmix
reviewed
Jul 1, 2024
Co-authored-by: mix irving <[email protected]>
mixmix
suggested changes
Jul 1, 2024
There was a problem hiding this comment.
Great clear test, some nice refactoring, couple suggested tweaks.
The only one I want us all to agree on is:
- https://github.com/entropyxyz/cli/pull/140/files#r1661560792 - how flexy are our atomic functions (team decision, I'll discuss with Frankie when I catch up with her)
The other one about getKeyring I'm happy to be flexible on, so long as you consider what I've said and thought about future cost of what you're changing
|
@mixmix @frankiebee this is ready for re-review |
frankiebee
reviewed
Jul 2, 2024
Comment on lines
3
to
+6
| // @ts-ignore | ||
| import { spinNetworkUp, spinNetworkDown, } from "@entropyxyz/sdk/testing" | ||
| // @ts-ignore | ||
| import Keyring from '@entropyxyz/sdk/keys' |
There was a problem hiding this comment.
is their an an issue for this on sdk? this dosent look good. why?
frankiebee
approved these changes
Jul 2, 2024
mixmix
reviewed
Jul 3, 2024
| import cliProgress from 'cli-progress' | ||
| import colors from 'ansi-colors' | ||
|
|
||
| export function setupProgress (label: string): { start: () => void; stop: () => void } { |
mixmix
reviewed
Jul 3, 2024
| @@ -0,0 +1,7 @@ | |||
| // @ts-ignore | |||
| import { Pair } from '@entropyxyz/sdk/keys' | |||
| export interface TransferOptions { | |||
mixmix
reviewed
Jul 3, 2024
| @@ -0,0 +1,82 @@ | |||
| import test from 'tape' | |||
| import { wasmGlobalsReady } from '@entropyxyz/sdk' | |||
| // WIP: I'm seeing problems importing this? | |||
There was a problem hiding this comment.
Is it resolved in the SDK that is un-published yet I wonder
mixmix
approved these changes
Jul 3, 2024
|
Great work @rh0delta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #124