Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev process && CHANGE.log First Pass #105

Merged
merged 9 commits into from
Jun 21, 2024
Merged

Conversation

frankiebee
Copy link
Collaborator

@frankiebee frankiebee commented Jun 12, 2024

Let this be the beginning of defining process for this project.
i cp'd the template here sense templates wont populate till in main
i included the issue number before creating this pr and checked the boxs after opening it
closes #104

  • Do you think code didn't change in this PR?

  • Did you include an issue for this PR

  • Did you write test for this PR?
    No "testing environment for this change" other then to just merge it in to see the template in future PR

  • Did you write documentation in some form for this PR?

  • Did you request a reviewer for this PR that did not include commits?
  • Did this get QA'd by someone else
  • Did you include a CHANGELOG.md entry?

@frankiebee frankiebee requested review from mixmix and rh0delta June 12, 2024 23:49
rh0delta
rh0delta previously approved these changes Jun 14, 2024
@frankiebee frankiebee marked this pull request as ready for review June 18, 2024 18:28
@frankiebee frankiebee changed the base branch from main to dev June 18, 2024 18:29
@frankiebee frankiebee dismissed rh0delta’s stale review June 18, 2024 18:29

The base branch was changed.

@frankiebee frankiebee added the documentation Improvements or additions to documentation label Jun 18, 2024
@frankiebee frankiebee changed the base branch from dev to main June 18, 2024 19:14
@frankiebee frankiebee changed the title dev process && CHANGE.log dev process && CHANGE.log First Pass Jun 18, 2024
@frankiebee frankiebee changed the base branch from main to dev June 18, 2024 19:15
@rh0delta rh0delta merged commit 93c3d05 into dev Jun 21, 2024
@rh0delta rh0delta deleted the frankie/i#104-dev-process branch June 21, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We Need Process!
3 participants