Build updates and modernization #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
changed the title
|
@corranwebster This is ready for review, if you have the bandwidth available. |
mdickinson
commented
Mar 13, 2023
Sorry, I take that back. The juggling with the changes in #526 is getting annoying; I think it makes most sense to merge that PR into this one. I'll change back to draft while that's in progress. |
[PR includes commits from, and extends, #513] This PR updates our testing machinery in two ways: - We no longer rely on `ETS_TOOLKIT` (or `QT_API`) being set in order to run tests that require a GUI; we just rely on Pyface's default mechanisms for toolkit detection. (As a consequence, we retain the option to _use_ `ETS_TOOLKIT` if it's helpful.) - `etstool.py` support for backends other than those available through EDM has been removed. Meanwhile, support for `pyqt6` has been added. (Tests currently fail with PyQt6, due to a known issue in TraitsUI: enthought/traitsui#1926) Closes #525 Closes #370
This was referenced Mar 13, 2023
corranwebster
approved these changes
Mar 14, 2023
This was referenced Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the build machinery to use pyproject.toml, and drops Python 3.6 support.
Detailed changes
setup.cfg(which only containedflake8configuration settings) to.flake8setup.pywithpyproject.tomlsetup.pyenvisage.versionandenvisage.__version__(and tests)extras_require) have been removedETS_TOOLKIT(orQT_API) being set in order to run tests that require a GUI; we just rely on Pyface's default mechanisms for toolkit detection. (As a consequence, we retain the option to useETS_TOOLKITif it's helpful.)etstool.pysupport for backends other than those available through EDM has been removed. Meanwhile, support forpyqt6has been added. (Tests currently fail with PyQt6, due to a known issue in TraitsUI: QEvent.Type error seen on Windows 10 + Python 3.8 + PyQt6 backend traitsui#1926)Closes #370
Closes #511
Closes #512
Closes #519
Closes #525