Use the "sphinx-copybutton" extension in documentation #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: docs/source/conf.py modified: etstool.py modified: setup.py
… was worth on Traits
mdickinson
reviewed
Aug 11, 2022
etstool.py
Outdated
| @@ -241,6 +244,14 @@ def install(edm, runtime, toolkit, environment, editable, source): | |||
| "{edm} run -e {environment} -- python -m pip install wxPython" | |||
| ) | |||
|
|
|||
| if pypi_dependencies: | |||
There was a problem hiding this comment.
This if seems redundant: if pypi_dependencies is empty, then no commands will be appended.
mdickinson
reviewed
Aug 11, 2022
Remove redundant if statement
mdickinson
reviewed
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
sphinx_copybuttonextension when building the Sphinx documentationsphinx-copybuttonadocsextra for theenvisagepackagepypi_dependenciessection to theetstoolutility and addsphinx-copybuttonas a PyPI dependency for the moment.Ref https://sphinx-copybutton.readthedocs.io/en/latest/