Backport PRs #421, #422 and #423 #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "Support observe("name:items") for ExtensionPoint [Requires Traits 6.1] (#354)"
This reverts commit d62af08.
* TST/FIX : Revert test that used observe to listen to changes to
extension point items. The test now uses a static trait change handler
like before
modified: envisage/tests/test_plugin.py
* Add failing test * STY: Fix line spacing issues Co-authored-by: Poruri Sai Rahul <[email protected]>
* Fix hard test suite dependence on ipykernel * Update envisage/tests/test_ids.py Co-authored-by: Poruri Sai Rahul <[email protected]> Co-authored-by: Poruri Sai Rahul <[email protected]>
modified: CHANGES.rst
aaronayres35
approved these changes
Jun 17, 2021
Yup. We (@mdickinson ) settled on that because we're fixing a broken feature (the fix here is to effectively remove the feature). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the following PRs back to the
maint/6.0branch in preparation for the 6.0.1 release - #421 , #422 and #423 . #422 reverted the original PR that is the cause of #417 , #421 adds a regression test for #417 and #423 ensures that the testsuite passes cleanly with minimal dependencies.This PR also updates the changelog in preparation for the upcoming release. Once this PR is merged, we will be in a place to make the 6.0.1 release.