Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Folder Structure #52

Merged
merged 4 commits into from
Apr 15, 2021
Merged

Folder Structure #52

merged 4 commits into from
Apr 15, 2021

Conversation

Till-B
Copy link
Collaborator

@Till-B Till-B commented Apr 12, 2021

New folder structure (divide into list, chat, etc.)

@antonykamp
Copy link
Member

Hello my friend,

  • To achieve urls like "entel.me/chats/12345" for a single chat the file [chaidId].tsx has to be in a folder .../pages/chats/ :) (that's probably the reason for one merge conflict too)
  • Maybe we have to rethink the pages folder. We have so few pages. Does it even make sense to separate them? Especially when half of the list pages are in index.tsx. What do you think? :)

@antonykamp antonykamp temporarily deployed to entel-dev-pr-52 April 12, 2021 18:58 Inactive
@antonykamp
Copy link
Member

Hello again :D Please merge the develop branch into Folder-Structure-develop after #67 #65 #63 and the PRs of #36, #38 are merged. Then you can resolve the merge conflicts locally and deploy your branch as a preview-app on heroku :)

@antonykamp antonykamp merged commit f13d282 into entel-me:develop Apr 15, 2021
@antonykamp antonykamp mentioned this pull request May 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Till-B @antonykamp