ENDOC-801 7.3.1-new env vars EntApp CRD #827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| |`spec.dbms` | Allowed values are: MySQL, PostgreSQL (default), Oracle, or embedded. Oracle is only supported as an external database.| | ||
| |`spec.ecrGitSshSecretName`| The configuration used by the Entando Component Manager to download bundles from authenticated Git repositories. It's a Secret containing a private key file named `rsa_id` that matches a public key configured in the authenticated Git repository.| | ||
| |`spec.environmentVariables`| A map of environment variables to pass to the EntandoApp Docker image. These variables pass to all components, and can sometimes be used as a mechanism to override any of the default environment variables that need customization.| |
There was a problem hiding this comment.
There is no EntandoApp docker image.
An EntandoApp is a only custom resource that is used to configure and manage 3 sub-modules (ComponentManager, AppEngine, AppBuilder) and their respective docker images.
The variables set under this property are propagated to all the 3 modules.
There was a problem hiding this comment.
P.S.
unless you were referring to the EntandoApp controller
There was a problem hiding this comment.
@w-caffiero-entando, that confused me a bit as well but it was there previously so I didn't mess with it. Will correct it now.
jyunmitch
commented
Jun 26, 2024
| |`spec.ecrGitSshSecretName`| The configuration used by the Entando Component Manager to download bundles from authenticated Git repositories. It's a Secret containing a private key file named `rsa_id` that matches a public key configured in the authenticated Git repository.| | ||
| |`spec.environmentVariables`| A map of environment variables to pass to the EntandoApp Docker image. These variables pass to all components, and can sometimes be used as a mechanism to override any of the default environment variables that need customization.| | ||
| |`spec.environmentVariables`| A set of environment variables mapped to the Docker images of the App Builder, App Engine, and Component Manager. They can be used as a mechanism to override any of the default environment variables that need customization.| |
There was a problem hiding this comment.
@w-caffiero-entando, Is this better? can you approve this PR if this is okay?
antoalv19
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
***** Will not merge until 7.3.1 Release *****