Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-399 Add a tutorial for changing the context of the entando-de-app #664

Merged
merged 3 commits into from
Jan 25, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions vuepress/docs/.vuepress/next.js
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,10 @@ module.exports = {
title: 'Configure the Entando Operator',
path: path + 'devops/entando-operator.md',
},
{
title: 'Configure the Entando App Context',
path: path + 'devops/entando-de-app.md',
},
]
},
]
Expand Down
39 changes: 39 additions & 0 deletions vuepress/docs/next/tutorials/devops/entando-de-app.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
---
sidebarDepth: 2
---

# Configure the Entando App Context
This tutorial describes how to modify the [EntandoApp CRD](../../docs/consume/entandoapp-cr.md) to customize the context path of an Entando App Engine deployment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, CR rather than CRD.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"context path" -> "ingress path".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshaw should any/all of the CRDs on the linked page be corrected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also luigi said "in the entandoapp CRD" ?? i feel like we might need to take another pass at the docs to straighten out CR/CRD mentions ??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's incorrect, also incorrect in the opening paragraph of this page. The only CRDs are the cluster-scoped definitions (all with kind: CustomResourceDefinition) which define what the custom resources (CRs) are. An EntandoApp is a custom resource. Maybe we can try to fix this page and then open a ticket for further docs review.


## Prerequisites
- An existing deployment of an Entando App or the ability to create one.
- If you haven't created a deployment or don't have a YAML file for an Entando deployment, follow the [Quickstart instructions](../../docs/getting-started/README.md).

## Remove or Replace entando-de-app

The web context of the App Engine currently defaults to **/entando-de-app**, which is visible in the URL. Follow the steps below to remove or replace this value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"web context" -> "ingress path"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshaw should we change the language in the table on the linked page?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lyd1aCla1r3 Maybe I'm missing it. The getting-started/README seems okay to me

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshaw sorry - this page https://developer.entando.com/next/docs/consume/entandoapp-cr.html - the table entry for ingressPath

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lyd1aCla1r3 hah, that may have been one I was looking at. Yeah, I think we should clean that up. And it could be useful to add it to the navigation under consume since it's an important reference and hard to find right now.


1. Open the `entando-app.yaml`, which contains several default paramters:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"paramters" -> "parameters"


```yaml
apiVersion: entando.org/v1
kind: EntandoApp
metadata:
namespace: entando
name: quickstart
spec:
environmentVariables: null
dbms: embedded
ingressHostName: YOUR-HOST-NAME
standardServerImage: eap
replicas: 1
```

2. Under `spec`, add the parameter `ingressPath`. If this parameter is not present, the path for the `entando-de-app` defaults to **/entando-de-app**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entando-de-app >> EntandoApp

it sounded a bit funny repeated here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wanted to make the connection that the EntandoApp's server-side/consumer representation was the Entando App Engine, aka the entando-de-app... otherwise it's like, why this default? subtle and repetitive but technically correct and connects some dots...


3. Input a value for `ingressPath` to change the web context:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input a value >> enter a value or null values to...

it doesn't explain the two different options

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm i actually think this drives home the point that something needs to be entered; a null value is still a value, like 0 is still a value. if you add the parameter and leave the field blank things break

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes it sound as if you have to enter a value by this instruction, but the second option below says otherwise. And null value is a blank or no value. 0 is not a null value, pretty sure.

Reading the whole section I can see that there are two options. But just reading line 34, you are surprised that you can add a blank. That's all. and not a big deal

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but both 0 and null are values (you're right that 0 != null), as is a space, or empty quotes. i guess my point is that you have to add a character, even if that character is invisible. if you don't, it will error. so i didn't want to mislead and define values as only characters of a certain kind. i'll look at it again


- To remove mention of the deployment and show only a forward slash, set the value to empty (e.g.: "" ), blank (e.g.: " "), or "/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"To remove mention of the deployment" -> "To remove /entando-de-app from the path completely"


- To change the name of the deployment, enter a value of "YOUR-DEPLOYMENT-NAME/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "To change the visible path of the application, enter a value of "/YOUR-INGRESS-PATH".
  2. I don't think it should have a trailing slash, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right - slash on the wrong side :)