ENDOC-645 Support native k8s image builds in CI/CD pipelines #663
Conversation
| OR | ||
|
|
||
| - Setting the `skipDockerBuild` option allows the user to create a custom image build. No images are generated for the bundle and microservices, but the YAML descriptors and Dockerfile are created in the `.output` folder. | ||
| - The command `ent bundle images` returns the Docker image names and tags, which are used to manually build the bundle and microservice images in the `.output` and microservice folders, respectively. |
There was a problem hiding this comment.
I like this much better. The first one, you have to decipher what is what.
It should match the other flag formats on the page, like this one, it's much easier to read
--fail-fast:
- Fail the command as soon as any subtask fails
--max-parallel=<value>:- Maximum number of subtasks running simultaneously. The default value is 3. Setting
max-parallel=1results in a sequential process.
- Maximum number of subtasks running simultaneously. The default value is 3. Setting
There was a problem hiding this comment.
i liked the second better too. and yes, these bullets will fall under the commands listed above the first option
| @@ -105,6 +105,8 @@ See the [Build and Publish a Simple Bundle](../../tutorials/create/pb/publish-si | |||
| |`ent bundle pack`| Generate the bundle artifacts, the bundle image and the microservice images | | |||
| |`ent bundle pack --org [organization]`| Generate the bundle artifacts and images, passing the organization name to Docker Hub | | |||
| |`ent bundle pack --file [my-dockerfile]`| Use a custom Dockerfile for the bundle | | |||
| |`ent bundle pack -s`| Create YAML descriptors and bundle the Dockerfile | | |||
There was a problem hiding this comment.
is it bundling the Dockerfile?
There was a problem hiding this comment.
Nope. ent bundle pack --help says this "-s, --skip-docker-build Skip the building of Docker images"
There was a problem hiding this comment.
sorry! meant to fix this; copied it before looking at the ENG ticket...
| @@ -105,6 +105,8 @@ See the [Build and Publish a Simple Bundle](../../tutorials/create/pb/publish-si | |||
| |`ent bundle pack`| Generate the bundle artifacts, the bundle image and the microservice images | | |||
| |`ent bundle pack --org [organization]`| Generate the bundle artifacts and images, passing the organization name to Docker Hub | | |||
| |`ent bundle pack --file [my-dockerfile]`| Use a custom Dockerfile for the bundle | | |||
| |`ent bundle pack --skip-docker-build`| Skip the building of Docker images | | |||
There was a problem hiding this comment.
Add just "-s"? I think it would be helpful to let them know that -s works the same. Not sure if it belongs here or down below in the details.
There was a problem hiding this comment.
i was on the fence with this... we haven't been using shorthand and just recently changed all the ent ks to ent kubectl... the help text displays -s as an option so i think if they're in deep enough to need a shortcut it's readily available. we can discuss later, too
i am absolutely overthinking this. @jyunmitch which do you like better?