ENDOC-636 add env variables for retries & timeouts #657
Conversation
| @@ -29,6 +29,10 @@ spec: | |||
| |`spec.dbms` | Allowed values are: MySQL, PostgreSQL (default), Oracle, or embedded. Oracle is only supported as an external database.| | |||
| |`spec.ecrGitSshSecretName`| The configuration used by the Entando Component Manager to download bundles from authenticated Git repositories. It's a Secret containing a private key file named `rsa_id` that matches a public key configured in the authenticated Git repository.| | |||
| |`spec.environmentVariables`| A map of environment variables to pass to the EntandoApp Docker image. This can be used to provide connection details of custom datasources or message queues as discussed in the [custom datasources tutorial](../../tutorials/devops/change-default-datasource.md). These variables can sometimes be used as a mechanism to override any of the default environment variables that need customization.| | |||
| | `ENTANDO_ECR_DEAPP_REQUEST_RETRIES`| The environmentVariable that specifies the number of times the Componenent Manager retries the component create update process before stopping. Defaults to 3. | | |||
There was a problem hiding this comment.
Could remove the leading "The environmentVariable that specifies" text since they are all environment variables.
| | `ENTANDO_ECR_DEAPP_REQUEST_RETRIES`| The environmentVariable that specifies the number of times the Componenent Manager retries the component create update process before stopping. Defaults to 3. | | ||
| | `ENTANDO_ECR_DEAPP_REQUEST_BACKOFF` | The environmentVariable that specifies the number of seconds to wait before the next create attempt is executed. Defaults to 5. | | ||
| | `ENTANDO_ECR_POSTINIT` | The environmentVariable that specifies the configuration of the postinit process | | ||
| | `ENTANDO_CONTAINER_REGISTRY_CREDENTIALS` | The environmentVariable that specifies the configuration for authenticated OCI registries. | |
There was a problem hiding this comment.
Probably good to link to the corresponding tutorial since it provides more context - https://developer.entando.com/v7.1/tutorials/curate/bundle-private-images.html
| | `ENTANDO_ECR_DEAPP_REQUEST_RETRIES`| The number of times the Componenent Manager retries the component create/update process before stopping. Defaults to 3. | | ||
| | `ENTANDO_ECR_DEAPP_REQUEST_BACKOFF` | The number of seconds to wait before the next create attempt is executed. Defaults to 5. | | ||
| | `ENTANDO_ECR_POSTINIT` | The configuration of the postinit process | | ||
| | `ENTANDO_CONTAINER_REGISTRY_CREDENTIALS` | The configuration for authenticated [OCI registries](../../tutorials/curate/bundle-private-images.md). | |
There was a problem hiding this comment.
configuration of (like above)
There was a problem hiding this comment.
it this case, means the same
There was a problem hiding this comment.
There was a problem hiding this comment.
I think you can have configuration of something as well as configuration for something... in this case it can be configuration of a particular registry as well as configuration for any registries, in a general sense
| @@ -29,6 +29,10 @@ spec: | |||
| |`spec.dbms` | Allowed values are: MySQL, PostgreSQL (default), Oracle, or embedded. Oracle is only supported as an external database.| | |||
| |`spec.ecrGitSshSecretName`| The configuration used by the Entando Component Manager to download bundles from authenticated Git repositories. It's a Secret containing a private key file named `rsa_id` that matches a public key configured in the authenticated Git repository.| | |||
| |`spec.environmentVariables`| A map of environment variables to pass to the EntandoApp Docker image. This can be used to provide connection details of custom datasources or message queues as discussed in the [custom datasources tutorial](../../tutorials/devops/change-default-datasource.md). These variables can sometimes be used as a mechanism to override any of the default environment variables that need customization.| | |||
| | `ENTANDO_ECR_DEAPP_REQUEST_RETRIES`| The number of times the Componenent Manager retries the component create/update process before stopping. Defaults to 3. | | |||
There was a problem hiding this comment.
can we clarify stopping? does it fail? exit? errors logged? not asking for detail, it's just that "stopping" doesn't really give the user info -- "...before exiting" or "before failing and logging errors," etc.
There was a problem hiding this comment.
originally was "giving up". Maybe quitting is better. Can't clarify without more details from engineering but I think this would be a typical situation that doesn't need more details.
| | `ENTANDO_ECR_DEAPP_REQUEST_RETRIES`| The number of times the Componenent Manager retries the component create/update process before stopping. Defaults to 3. | | ||
| | `ENTANDO_ECR_DEAPP_REQUEST_BACKOFF` | The number of seconds to wait before the next create attempt is executed. Defaults to 5. | | ||
| | `ENTANDO_ECR_POSTINIT` | The configuration of the postinit process | | ||
| | `ENTANDO_CONTAINER_REGISTRY_CREDENTIALS` | The configuration for authenticated [OCI registries](../../tutorials/curate/bundle-private-images.md). | |
There was a problem hiding this comment.
No description provided.