ENDOC-628 generate MS and MFE Tutorial edit commands #652
Conversation
| ``` | ||
| >Note: On some Zsh interfaces, you may receive an invalid argument response that can be ignored as the long as the folders are relocated correctly. |
There was a problem hiding this comment.
not really happy with this, unsure how to put it
There was a problem hiding this comment.
-> "In some shells (e.g. zsh), you may receive an "invalid argument response" warning that can be ignored as long as the folders are relocated correctly.
There was a problem hiding this comment.
no comment per pending change to nathan's wording
| ``` | ||
| >Note: On some Zsh interfaces, you may receive an invalid argument response that can be ignored as the long as the folders are relocated correctly. |
There was a problem hiding this comment.
no comment per pending change to nathan's wording
| ent bundle api add conference-details conference-api --serviceName=conference-ms --serviceUrl=http://localhost:8081 | ||
| ent bundle api add conference-form conference-api --serviceName=conference-ms --serviceUrl=http://localhost:8081 | ||
| ``` | ||
| 5. For local development and testing, a custom command is needed in the `entando.json` to use a different port for each MFE, shown in the following: |
There was a problem hiding this comment.
...the entando.json requires a custom command to...
as shown here/below
There was a problem hiding this comment.
I tried the first item with "entando.json requires", but it doesn't read right because it is not the entando.json that requires it
There was a problem hiding this comment.
"...the entando.json must include..."
| @@ -22,7 +22,7 @@ ent bundle svc start keycloak | |||
| ``` sh | |||
| ent bundle run conference-ms | |||
| ``` | |||
| To check that the MS is working, go to `http://localhost:8081/`. In local development, the run command can be used to modify the port to run multiple microservices, but in production, microservices must run on port 8081. | |||
| To check that the MS is working, go to `http://localhost:8081/`. In local development, the run command can be used to modify the ports to run multiple microservices, but in production, microservices must run on port 8081. | |||
There was a problem hiding this comment.
"modify the ports to run multiple MSs" still reads that a single port can run multiple MSs. i think we don't need to add extra details or motivations here, just "to modify the port, but in..."
There was a problem hiding this comment.
reworded. "modify the port, but in production..." doesn't provide enough info
| c. Add the API claims | ||
| ```shell | ||
| ent bundle api add conference-details conference-api --serviceName=conference-ms --serviceUrl=http://localhost:8081 | ||
| ent bundle api add conference-form conference-api --serviceName=conference-ms --serviceUrl=http://localhost:8081 |
There was a problem hiding this comment.
a/b/c here don't end with : but the other instructions do
| @@ -62,7 +62,7 @@ ent bundle run simple-node-ms | |||
| * Access <http://localhost:8081/api/hello> to see a `Hello World!` response with a timestamp. | |||
| * Access <http://localhost:8081/api/health> to see a standard `{"status:"UP"}` response. | |||
|
|
|||
| In local development, the run command can be used to modify the port to run multiple microservices, but in production, microservices must run on port 8081. | |||
| In local development, custom commands can be used to modify ports to run each microservice, but in production, microservices must run on port 8081. | |||
There was a problem hiding this comment.
i think this is less clarified... prefer nathan's tweak to your original wording: In local development, the run command can be used to modify the port for a microservice, but in production microservices must run on port 8081.
There was a problem hiding this comment.
I wanted to include cases where there are multiple microservices because that's when this applies, not when there is just one
There was a problem hiding this comment.
In local development, the run command can be used to modify the port number so that multiple microservices can run in parallel on separate ports, but in production microservices must run on port 8081
No description provided.