-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENDOC-561 7.1 simple mfe react app #556
Conversation
@@ -98,7 +98,7 @@ npm start | |||
npm run build | |||
``` | |||
|
|||
6. Load the updated `my-widget` files into Entando as was done for the [React MFE tutorial](./react.md#upload-the-react-files) | |||
6. Load the updated `my-widget` files into Entando as was done for the [React MFE tutorial](../../../../v7.0/tutorials/create/mfe/react.md#upload-the-react-files) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a relative link so it points to the current version, rather than directly to v7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nshaw this is a tricky one because this section no longer exists in the current version, and it's not just a matter of renaming - we killed the content. i didn't look at the affected page closely enough to get a sense of how we might also modify it for v5, if at all, so just pointed back to 7.0 instead of removing the link reference and listing all the steps explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Lyd1aCla1r3 ah, understood. I have some ideas for it based on the Tableau widget conversion I'm working on so we can discuss on our next call.
npx create-react-app my-widget --use-npm | ||
``` | ||
This tutorial updates the following files: | ||
1. Initialize a new bundle project by scaffolding the default files and folders: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scaffolding the files and folders>> are we scaffolding files though, aren't we scaffolding the structure?
``` bash | ||
npx create-react-app simple-mfe --use-npm | ||
``` | ||
Use the bundle name you chose when adding an MFE to overwrite the empty bundle folder created in the previous step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confusing >> can you simplify to say create in previous step? doesn't seem like all the additional info is necessary
- `my-widget/static/css` | ||
- `my-widget/static/js` | ||
- `my-widget/static/media` | ||
4. Install the bundle in your Entando Application from `App Builder` → `Hub` or with the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awkward and confusing. It also reads like "install the bundle in your entando application from app builder to the Hub" I would break it up or edit
No description provided.