Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-536 new bundle classification #555

Merged
merged 6 commits into from
Aug 31, 2022
Merged

ENDOC-536 new bundle classification #555

merged 6 commits into from
Aug 31, 2022

Conversation

jyunmitch
Copy link
Collaborator

@jyunmitch jyunmitch commented Aug 24, 2022

No description provided.

@jyunmitch jyunmitch requested a review from nshaw August 24, 2022 19:36
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
vuepress/docs/next/docs/curate/bundle-version-types.md Outdated Show resolved Hide resolved
|Bundle Thumbnail| Detailed inside the YAML bundle descriptor|Automatically setup with a jpg or png file named thumbnail in the bundle root folder. e.g. thumbnail.png

* Alternate page titles
# Entando Bundle Version Comparison
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this one of the 3. I don't love Version in the title for some reason (since bundles themselves have versions when published) but I don't have a better idea. In some ways this is a Feature Matrix like you get when you do insurance shopping. Entando Bundle Feature Matrix?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about Entando Bundle Transition to 7.1?
Entando Bundle Transition from 7.0 to 7.1
How Entando Bundles changed from 7.0 to 7.1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature Matrix for Bundle Transition?

@@ -0,0 +1,39 @@
---
Copy link
Collaborator Author

@jyunmitch jyunmitch Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: changed file name...lost most of Nathan's comments but applied all of them here. The files are the same in this commit, I think

@jyunmitch jyunmitch requested a review from Lyd1aCla1r3 August 25, 2022 19:30

# Entando Bundle Transition to 7.1

Entando 7.1 implements a more modular approach to building apps with the **ent bundle** CLI orchestrating the management of project bundles. The Entando bundle was restructured, its processes decoupled by component type, and the publishing transport method was streamlined. With these changes, Entando Bundles went from git-based to Docker-based OCI bundles, and this page clarifies the differences between the two, along with the improvements that were made with the new release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Entando bundle -> The Entando Bundle

Docker-based -> docker-based

"Entando 7.1 implements a more modular approach to building apps with the ent bundle CLI orchestrating the management of project bundles." -> "Entando 7.1 implements a more modular approach to building apps with the ent bundle CLI**, which orchestrates** the management of project bundles." -- can we make this change so it's clear that the ent bundle tool is new? otherwise it could read that the ent bundle tool was modified wrt orchestration methods

"Entando Bundles went from git-based to Docker-based OCI bundles..." -- "went from" is a little ambiguous. could we make it clear that this bundle type was not overwritten, but instead a new kind of introduced? this reads like changes were made to the current bundle type, not that there are now two varieties


Some of the major improvements with the docker-based bundles are:
* Simplified bundle directory structure
* Just one source git repository required with Docker image repositories created automatically as needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wording here tripped me up... place "required" before "one" and add a comma? "Requires a single source git repository, with Docker image repositories created automatically as needed."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would make the tense different from all others in list

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one way to keep the tense and reword: "only one required Git source repository with Docker..." (also Git should be capitalized)

Some of the major improvements with the docker-based bundles are:
* Simplified bundle directory structure
* Just one source git repository required with Docker image repositories created automatically as needed
* Optimized file storage and transfer using a layered file-system, beneficial for large projects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no hyphen - "layered file system"

|Attribute | [git-based bundles](../../../v7.0/docs/curate/ecr-bundle-details.md)| [docker-based bundles](ecr-bundle-details.md)|
| :- | :-------------------- | :--------------------- |
|`descriptorVersion`| v1| v5
| Bundle specifications |Defined with descriptor files | Built with [ent bundle CLI](../getting-started/ent-bundle.md) tool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but "defined by"

| :- | :-------------------- | :--------------------- |
|`descriptorVersion`| v1| v5
| Bundle specifications |Defined with descriptor files | Built with [ent bundle CLI](../getting-started/ent-bundle.md) tool
| Versioning |Bundle version set by git tags |Bundle version set by Docker Tags. For MFEs, the version defaults to 1.0.0 unless set in the [entando.json](ecr-bundle-details.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Git tags" and "Docker tags" - uppercase for feature/platform & lowercase "tag"

|Export Bundle|`ent bundler`| Not Available
|JHipster Integrated Blueprint Project| `ent jhipster blueprint` creates [MFE & MS template project](../../tutorials/create/ms/generate-microservices-and-micro-frontends.md)| [Convert Blueprint project to v5 bundle](../../tutorials/create/ms/generate-microservices-and-micro-frontends.md) (TODO-change link to new tutorial)
|APIs| Not Available | [Manage APIs with `ent bundle` commands](../getting-started/ent-api.md). MFEs can make API claims to MSs within the namespace
||| MFEs support service discovery by using the property apiClaim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backtick "apiClaim" because it's a property ??

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's being used as a name of a thing, not referring to code?

|APIs| Not Available | [Manage APIs with `ent bundle` commands](../getting-started/ent-api.md). MFEs can make API claims to MSs within the namespace
||| MFEs support service discovery by using the property apiClaim
|Local Services |Not Available | Default services now include PostgreSQL, MySQL, and Keycloak. Additional services can be added with the [`ent bundle svc` commands](../getting-started/ent-svc.md).
|MFE custom UI| Add with manual scripts| Custom UI is auto-generated in FTL format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autogenerated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looked it up and they are both used, about equally

||| MFEs support service discovery by using the property apiClaim
|Local Services |Not Available | Default services now include PostgreSQL, MySQL, and Keycloak. Additional services can be added with the [`ent bundle svc` commands](../getting-started/ent-svc.md).
|MFE custom UI| Add with manual scripts| Custom UI is auto-generated in FTL format
|Data transfer | Manual | New ways to pass values or information to widgets, bundles, or expose in the APIs by [utilizing context parameters, system parameters and the ext variable](ecr-bundle-details.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentence fragment is awkward - "or expose in the APIs..." what do you mean by this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the APIs expose the values or information transferred, literally, probably in the browser or something like that

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the verb changed so the subject needs to be reintroduced somehow... "New ways to pass values to widgets and bundles or expose information in APIs by..."

|Bundle Thumbnail| Detailed inside the YAML bundle descriptor|Automatically setup with a jpg or png file named thumbnail in the bundle root folder. e.g. thumbnail.png

* Alternate page titles
# Entando Bundle Version Comparison
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature Matrix for Bundle Transition?

@@ -2,13 +2,13 @@
sidebarDepth: 2
---

# Entando Bundle Transition to 7.1
# Entando Bundle Transition to 7.1 Entando Bundle Evolution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like this!


Entando 7.1 implements a more modular approach to building apps with the **ent bundle** CLI orchestrating the management of project bundles. The Entando bundle was restructured, its processes decoupled by component type, and the publishing transport method was streamlined. With these changes, Entando Bundles went from git-based to Docker-based OCI bundles, and this page clarifies the differences between the two, along with the improvements that were made with the new release.
Entando 7.1 implements a more modular approach to building apps with the **ent bundle** CLI orchestrating the management of project bundles. The Entando bundle was restructured, its processes decoupled by component type, and the publishing transport method was streamlined. With these changes, Entando Bundles went from git-based to Docker-based OCI bundles. Though both systems are supported on Entando 7.1, this page clarifies the differences between the two, along with the improvements that were made with the new release.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entando bundle -> Entando Bundle (2nd sentence)
Docker-based -> docker-based (4th line)
system is not the right word here. implementations is an option

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it to methods, shorter than implementation

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's actually not a method, though... implementations is really the best word here. unless you want to use "bundle structures"

same comment as before applies to "went from"; don't know if you saw it. we need to make it clear that v1 and v5 bundles both exist, and that v1 bundles have not been converted over to v5. 7.1 introduces a new bundle format, but this does not impact existing bundles from 7.0 backwards. the conversion to turn v1 into v5 has to be done by the user

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the statement that both methods are supported suffices here. To get into too much detail is not fruitful when they can see the table of differences just below. And Nathan thought the summary worked. I don't want to say anything about conversion because, 1. not may people will be doing it without Entando's support as Nathan said, and 2. it makes it sound cumbersome right off the bat.

And methods, processes, implementations, they can all work on some level. and since it was just talking about transport methods, thought that would also suffice.

@@ -2,14 +2,13 @@
sidebarDepth: 2
---

# Bundle Evolution on Entando 7.1
# Bundle Evolution on Entando 7.1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new title, with more options below. vote on your favorite

Copy link
Member

@nshaw nshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the link to this new page from the release notes in this PR or do you have that in a TODO somewhere?

@jyunmitch jyunmitch merged commit 2080a0c into main Aug 31, 2022
@jyunmitch jyunmitch deleted the ENDOC-536-version branch August 31, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants