ENDOC-556 Update Amazon EKS install instructions #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyunmitch
approved these changes
Aug 25, 2022
Lyd1aCla1r3
reviewed
Aug 25, 2022
| @@ -39,7 +39,7 @@ These steps use the AWS console to create the cluster. Experienced AWS users may | |||
| 8. Name your role (you’ll need this later), e.g. YOUR-EKS-ROLE | |||
| 9. Click `Create role` | |||
|
|
|||
| 3. Refine the role to enable `Node Group` management and add elastic load balancer (ELB) access so the cluster can deploy the ELB for NGINX | |||
| 3. Refine the role to enable `Node Group` management and add Elastic Load Balancer (ELB) access so the cluster can deploy the ELB for NGINX | |||
There was a problem hiding this comment.
should we fix this in the wiki? https://github.com/entando/entando-docs/wiki/Terminology
There was a problem hiding this comment.
@Lyd1aCla1r3 yeah, I think so. "load balancing" is a generic term and therefore lowercase. "Elastic Load Balancing" is the actual Amazon feature (so I should fix the name here) and capitalized in their docs - https://aws.amazon.com/elasticloadbalancing/getting-started/?nc=sn&loc=4
Lyd1aCla1r3
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.