ENDOC-522 new edits & Engr comments #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyd1aCla1r3
reviewed
Aug 13, 2022
| |`ent ecr generate-cr`|Generate the custom resource | | ||
| |`ent ecr get-bundle-id [repository-url]` | Calculate and display the bundle ID | ||
| |`ent ecr get-plugin-id --auto [repository-url]` | Calculate and display the plugin ID | ||
| |`ent ecr get-plugin-code --auto --repo=[repository-url]` |Calculate and display the plugin code for a Git-based v1 bundle| | ||
| |`ent ecr get-plugin-code [component-name] --repo=[repository-url]` | Calculate and display the plugin code for a Docker-based v5 bundle |
There was a problem hiding this comment.
same as above; docker-based and no v5
There was a problem hiding this comment.
Agree, just remove v5 from the note.
| @@ -163,4 +165,4 @@ These ent CLI commands are required when using a Git-based (v1) bundle. | |||
| ent appname YOUR-APPNAME | |||
| ent namespace YOUR-NAMESPACE | |||
| ``` | |||
| Check out [Run Blueprint-generated Microservices and Micro Frontends in Dev Mode](../../tutorials/create/ms/run-local.md) for additional information. | |||
| Follow the [Build and Publish a Project Bundle](../../tutorials/create/pb/publish-project-bundle.md) tutorial for more details about bundling your next Docker-based project. | |||
There was a problem hiding this comment.
awkward/confusing wording. and can apply to creating bundles for your current project, not just what you do next
There was a problem hiding this comment.
will when the actual tutorial has a new title so will change with that
nshaw
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.