Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-528 Add OKD 4.8 work-around comment on PDA page #539

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

Lyd1aCla1r3
Copy link
Contributor

No description provided.

@Lyd1aCla1r3 Lyd1aCla1r3 requested review from nshaw and jyunmitch July 21, 2022 20:32

<details><summary>Workaround for PDA connections on OpenShift 4.8</summary>

The PDA Plugin connections cannot be configured for RedHat OpenShift 4.8 implementations of Entando 7 due to missing rules on the entando-plugin Role. To circumvent a connections error, add the following definition to `namespace-resources.yaml`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change, my notes were not clear. "To circumvent a connections error, update the entando-plugin Role by adding the missing rules below."

I'm leaving it a little vague since you could do this with kubectl, k9s, or in the OpenShift UI like I did. This requires a bit of k8s knowledge of course.

I know for sure we need this on the 7.0 codebase but I'm unsure about 7.1 until we test. Maybe tweak this, add it to 7.0, and then add a note to our 7.1 TODOs to review later?


<details><summary>OpenShift 4.8 requires a workaround</summary>

An incomplete role definition prevents Entando 7 from configuring the PDA Plugin connections on RedHat OpenShift 4.8. As a workaround, update the entando-plugin Role by adding the missing rules below.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this supposed to have the bit about circumventing the connection error? otherwise everything else looked fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reworded it... "circumventing" (my word choice) sounded not quite right; it implies dodging something that's an inevitability. "workaround" is standard language for a quick and dirty - and temporary - fix. but explicitly calling out that something will error gives off an unfinished, amateur vibe, instead of finessing the inferences like in the revision.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the mention of an error is not necessarily a good thing but sometimes I think the meaning starts to get a bit vague. In this case, it is understandable but not crystal clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point

@Lyd1aCla1r3 Lyd1aCla1r3 merged commit 41750ff into main Jul 25, 2022
@nshaw nshaw deleted the ENDOC-528 branch August 26, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants