-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENDOC-495 RBAC tutorial cleanup #506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor suggestions but looks much improved overall. Once we unblock you I just want to know if it works from start to finish, and then eventually apply it to v7.0 as well.
* Remove the @Component annotation on the class definition: | ||
```java | ||
* Remove the @Component annotation on the class definition | ||
```java{1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for the most part, the instructions reads much clearer now, especially with the highlighted code and maybe I've become more familiar with it. I'm guessing those familiar with Java will not flounder as we did. But wondering can annotation refer to multiple lines? Annotation to me could be single or many lines and that made it hard to get a firm idea of what to implement or look for. But if annotation is commonly used to refer to single lines of code, then this is a moot point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jyunmitch Annotation is a Java feature, indicated by a line beginning with @something. I'm reasonably sure it cannot be multi-line, certainly 99% of annotations are one line even if the spec allows more. https://docs.oracle.com/javase/tutorial/java/annotations/basics.html
No description provided.