ENDOC-487 correct links #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyunmitch
commented
Apr 21, 2022
| @@ -17,7 +17,7 @@ The first step demonstrates how to create a Secret for Docker Hub but please see | |||
| **1. Create the secret** | |||
| Supply the following parameters: | |||
| * the name of the new Secret, e.g. `my-docker-secret`. | |||
| * the URL to your registry server. For Docker Hub this is currently <https://index.docker.io/v1/> | |||
| * the URL to your registry server. For Docker Hub this is currently <https://hub.docker.com/_/registry> | |||
There was a problem hiding this comment.
@nshaw, is this new link correct?
There was a problem hiding this comment.
Let's keep the original value. My docker info still reports that URL to identify the registry.
nshaw
requested changes
Apr 21, 2022
| @@ -17,7 +17,7 @@ The first step demonstrates how to create a Secret for Docker Hub but please see | |||
| **1. Create the secret** | |||
| Supply the following parameters: | |||
| * the name of the new Secret, e.g. `my-docker-secret`. | |||
| * the URL to your registry server. For Docker Hub this is currently <https://index.docker.io/v1/> | |||
| * the URL to your registry server. For Docker Hub this is currently <https://hub.docker.com/_/registry> | |||
There was a problem hiding this comment.
Let's keep the original value. My docker info still reports that URL to identify the registry.
nshaw
reviewed
Apr 22, 2022
| @@ -17,7 +17,7 @@ The first step demontrates how to create a secret for Docker Hub but please see | |||
| **1. Create the secret** | |||
| Supply the following parameters: | |||
| * the name of the new secret, e.g. `my-docker-secret`. | |||
| * the URL to your registry server. For Docker Hub this is currently <https://index.docker.io/v1/> | |||
| * the URL to your registry server. For Docker Hub this is currently <https://hub.docker.com/_/registry> | |||
nshaw
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.