Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENDOC-447 Change host names to single #482

Merged
merged 3 commits into from
Apr 13, 2022
Merged

ENDOC-447 Change host names to single #482

merged 3 commits into from
Apr 13, 2022

Conversation

jyunmitch
Copy link
Collaborator

No description provided.

@jyunmitch jyunmitch requested a review from Lyd1aCla1r3 April 12, 2022 13:50
@@ -201,7 +197,7 @@ python3 -m http.server 8000
13. You should now be able to install Entando using the static IP. If your Entando installation stalled during startup, and was previously configured with a static IP, it should continue initializing as soon as the external address is functional again.

#### Option 4: Reinstall Entando
We're including this option because it works and requires no additional configuration. If you plan to regularly work with Entando we recommend developing against a centralized and shared Kubernetes instance rather than running a full stack locally. If you require a local cluster we recommend using option 1 or 2.
We're including this option because it works and requires no additional configuration. If you work with Entando regularly, we recommend developing in a centralized and shared Kubernetes instance rather than running a full stack locally. If you require a local cluster, we recommend using option 1 or 2.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshaw can you comment on the use of "against" vs "in" here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lyd1aCla1r3 I think "in" is better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nshaw i was wondering what it meant to develop against an environment... is that common phrasing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lyd1aCla1r3 it's not that unusual. The only comparison I can think of is when you develop "against" or "towards" a standard, basically with a goal of meeting a target. I do think "in" is a bit better but just personal opinion/preference on this one. We log in to or shell/ssh into a VM, we log on to a cloud provider, we deploy into Entando, pods run in Kubernetes...

```
- If you add microservices to your installation, you may need to add additional mappings for the new ingresses.
- See [this section below](#option-2-manually-update-your-hosts-file) for detailed steps to perform this on Windows.
- To update files on a Windows machine, see the [Windows process](#option-2-manually-update-your-hosts-file) below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on Windows (nix machine - that gets into tricky territory with emulators, etc. safer to confine references to the OS layer.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, just say "on Windows"


### `.nip.io isn't allowed`
- This could be due to firewall settings or corporate security policies. The simplest workaround is to manually edit your /etc/hosts file and map the necessary domains to the IP of your local virtual machine.
- This could be due to firewall settings or corporate security policies. The simplest workaround is to manually edit your /etc/hosts file and map the necessary domain to the IP of your local virtual machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one domain? if just one can omit "necessary"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Just one domain now.

@jyunmitch jyunmitch merged commit 7bc7a60 into main Apr 13, 2022
@nshaw nshaw deleted the ENDOC-447 branch August 26, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants