endoc-425 deadlinkchecker cleanup #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyunmitch
commented
Feb 14, 2022
| @@ -22,11 +22,11 @@ Create a project, ideally in Git repository, and put the following files in the | |||
| It is essential for your custom Docker image to use a file from one of the official Entando Docker base images. | |||
|
|
|||
| If you intend to use provide your own EAP based image, please use this | |||
| [standalone-openshift.xml](https://github.com/entando/entando-docker-base-images/blob/master/entando-eap71-clustered-base/standalone-openshift.xml) | |||
| [standalone-openshift.xml](https://github.com/entando/entando-app-engine-base/blob/develop/eap/standalone-openshift.xml) | |||
There was a problem hiding this comment.
@nshaw, please check that this and the following two links to repos are the correct ones.
nshaw
requested changes
Feb 14, 2022
| @@ -22,11 +22,11 @@ Create a project, ideally in Git repository, and put the following files in the | |||
| It is essential for your custom Docker image to use a file from one of the official Entando Docker base images. | |||
|
|
|||
| If you intend to use provide your own EAP based image, please use this | |||
| [standalone-openshift.xml](https://github.com/entando/entando-docker-base-images/blob/master/entando-eap71-clustered-base/standalone-openshift.xml) | |||
| [standalone-openshift.xml](https://github.com/entando/entando-app-engine-base/blob/develop/eap/standalone-openshift.xml) | |||
| @@ -35,7 +35,7 @@ may have unintended consequences. | |||
| #### 1.2. Any modules that may be required for your datasource or other connection resource | |||
| If the resource you need to connect to requires some custom classes, such as JDBC drivers, please add these as | |||
| a module to Wildfly/EAP. As an example, you can look at our | |||
There was a problem hiding this comment.
Let's remove the "As an example" sentence plus the following sentence. It's not an equivalent resource for the example here and I don't see an obvious one off hand.
nshaw
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.