Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENDOC-374 Update the AWS install guide for 6.3.2. Update the k8s vers… #339

Merged
merged 2 commits into from
Nov 10, 2021
Merged

ENDOC-374 Update the AWS install guide for 6.3.2. Update the k8s vers… #339

merged 2 commits into from
Nov 10, 2021

Conversation

nshaw
Copy link
Contributor

@nshaw nshaw commented Nov 10, 2021

…ion in the azure install guide.

jyunmitch
jyunmitch reviewed Nov 10, 2021
View reviewed changes
Copy link
Collaborator

@jyunmitch jyunmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not repeat comments for the same changes in a different file. Maybe should do that?

@Lyd1aCla1r3
Copy link
Contributor

The use of periods is supremely inconsistent... Should we be focused on your edits alone or documents as a whole? I want to pull this to VSCode to view the modified files in Vuepress and make changes within my local environment - a more sophisticated collaboration where multiple branches and contributors affect a common file. :) Overkill?

@nshaw nshaw merged commit c3fac49 into main Nov 10, 2021
@nshaw nshaw deleted the ENDOC-374-aws-install branch November 10, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyunmitch jyunmitch jyunmitch approved these changes

@Lyd1aCla1r3 Lyd1aCla1r3 Awaiting requested review from Lyd1aCla1r3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nshaw @Lyd1aCla1r3 @jyunmitch