Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisions as a training exercise #329

Merged
merged 5 commits into from
Oct 28, 2021
Merged

Conversation

Lyd1aCla1r3
Copy link
Contributor

stumbling to the finish line...

@nshaw nshaw requested review from jyunmitch and nshaw October 27, 2021 12:26
Copy link
Member

@nshaw nshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as "request changes" but we can discuss on standup. Lots of improvements here and some things for us to sort out together.

Copy link
Member

@nshaw nshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small changes but looks close and definitely an improvement. I only commented on next but same will apply to 6.3.2


![Redis Caching](./redis-caching.png)

The Redis cache is not deployed by the Entando Operator and must be managed by the implementing teams dev ops or Kubernetes cluster administrators.
The Redis cache is not deployed by the Entando Operator and must be managed by the DevOps of implementation teams or Kubernetes cluster administrators.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "DevOps team member" instead of "DevOps of implementation teams" which reads a bit awkward.

@nshaw nshaw merged commit 4a4cdc8 into main Oct 28, 2021
@nshaw nshaw deleted the V6.3.2_reference_caching-and-clustering branch November 1, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants