Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Documentation and Build Settings #993

Merged
merged 7 commits into from
Jul 21, 2020
Merged

Update Documentation and Build Settings #993

merged 7 commits into from
Jul 21, 2020

Conversation

radeusgd
Copy link
Member

@radeusgd radeusgd commented Jul 10, 2020 •
edited
Loading

Pull Request Description

After the CLI distribution design discussion #987, some documentation had to be updated to reflect the decisions made.

Closes #987.

Important Notes

  • It renames the enso.jar to runner.jar, but the simple launcher script that is put in the bin directory is still enso.

Checklist

Please include the following checklist in your PR:

  • The documentation has been updated if necessary.
  • All code conforms to the Scala, Java, and Rust style guides.
  • All code has been tested where possible.

@radeusgd radeusgd added Type: Enhancement --breaking Important: a change that will break a public API or user-facing behaviour p-high Should be completed in the next sprint labels Jul 10, 2020
@radeusgd radeusgd self-assigned this Jul 10, 2020
@radeusgd radeusgd force-pushed the wip/rw/launcher-design-updates branch 6 times, most recently from d5661fd to 23b1baf Compare July 16, 2020 16:53
@radeusgd radeusgd added Change: Non-Breaking and removed --breaking Important: a change that will break a public API or user-facing behaviour labels Jul 17, 2020
@radeusgd radeusgd force-pushed the wip/rw/launcher-design-updates branch from 23b1baf to d32ea94 Compare July 17, 2020 12:29
@radeusgd radeusgd changed the title [WIP] Update Documentation and Build Settings Update Documentation and Build Settings Jul 17, 2020
@radeusgd radeusgd force-pushed the wip/rw/launcher-design-updates branch from d32ea94 to 24d94f0 Compare July 17, 2020 12:37
@radeusgd radeusgd marked this pull request as ready for review July 17, 2020 12:37
@radeusgd radeusgd requested a review from wdanilo July 17, 2020 12:38
iamrecursion
iamrecursion approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@iamrecursion iamrecursion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, super happy with this. Some minor cosmetic fixes

docs/distribution/distribution.md Outdated Show resolved Hide resolved
docs/distribution/distribution.md Outdated Show resolved Hide resolved
docs/distribution/distribution.md Outdated Show resolved Hide resolved
kustosz
kustosz approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@kustosz kustosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we'll get the portable distribution as well <3

@radeusgd radeusgd force-pushed the wip/rw/launcher-design-updates branch 3 times, most recently from d291ae6 to 6e140c1 Compare July 20, 2020 14:16
@radeusgd radeusgd force-pushed the wip/rw/launcher-design-updates branch from 6e140c1 to d80bcc9 Compare July 20, 2020 15:25
@radeusgd radeusgd mentioned this pull request Jul 20, 2020
Merged
3 tasks
wdanilo
wdanilo approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@wdanilo wdanilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it <3

@radeusgd radeusgd merged commit 1a38f7c into main Jul 21, 2020
@radeusgd radeusgd deleted the wip/rw/launcher-design-updates branch July 21, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamrecursion iamrecursion iamrecursion approved these changes

@wdanilo wdanilo wdanilo approved these changes

@kustosz kustosz kustosz approved these changes

@4e6 4e6 4e6 approved these changes

@lolczak lolczak Awaiting requested review from lolczak

Assignees

@radeusgd radeusgd

Labels
p-high Should be completed in the next sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI Distribution Design Discussion
5 participants
@radeusgd @4e6 @kustosz @wdanilo @iamrecursion