Abort jobs as early as possible #9927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't seem to run `abortJobs` under a lock, and especially not under the write compilation lock, in other scenarios. This is causing some major slowdown when there is a long running execution or compilation, as currently experienced in the cloud. This should reduce chances of a timeout.
hubertp
added
the
CI: No changelog needed
JaroslavTulach
approved these changes
May 13, 2024
| @@ -130,6 +130,7 @@ class CollaborativeBuffer( | |||
| stop(Map.empty) | |||
|
|
|||
| case IOTimeout => | |||
| logger.warn("Timeout reached when awaiting file's content") | |||
There was a problem hiding this comment.
Wouldn't be this the right moment to dump all stacktraces or turn on profiling?
There was a problem hiding this comment.
Not there yet, but yes, probably.
| @@ -42,12 +42,12 @@ public Future<BoxedUnit> executeAsynchronously(RuntimeContext ctx, ExecutionCont | |||
| private void setExecutionEnvironment( | |||
| Runtime$Api$ExecutionEnvironment executionEnvironment, UUID contextId, RuntimeContext ctx) { | |||
| var logger = ctx.executionService().getLogger(); | |||
| ctx.jobControlPlane().abortJobs(contextId); | |||
There was a problem hiding this comment.
This PR is moving abortJobs call outside of critical section, right? But the PR description says:
We don't seem to run abortJobs under a lock
How's that accurate? We do seem to run abortJobs under a lock and this PR is changing that, am I not right?
There was a problem hiding this comment.
I meant in other locations that call abortJobs
hubertp
added a commit
that referenced
this pull request
May 13, 2024
`System.getProperty` does not return `null`, it returns `"null"` :facepalm:. I broke the internet, sorry.
Merged
hubertp
added a commit
that referenced
this pull request
May 13, 2024
This was referenced May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
We don't seem to run
abortJobsunder a lock, and especially not under the write compilation lock, in other scenarios. This is causing some major slowdown when there is a long running execution or compilation, as currently experienced in the cloud.This should reduce chances of a timeout.
Also added an option to override the global executor. Currently it would always default to the runtime number of available process which may be suboptimal.
Important Notes
Pending testing on the impact it will have.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.