Consider autoscoped name when looking up dynamic config #9916
Conversation
vitvakatu
added
CI: No changelog needed
| return cfg.possibleFunctions.get(name) | ||
| const fullName = entryQn(info?.suggestion) | ||
| const autoscopedName = '..' + info?.suggestion.name | ||
| return cfg.possibleFunctions.get(fullName) ?? cfg.possibleFunctions.get(autoscopedName) |
There was a problem hiding this comment.
Should we always check autoscoped name here, or is supposed to be limited only to cases where the suggestion is an enum constructor?
Also I think this logic change should be included in possibleFunctions property documentation. It no longer typically contains only FQNs.
There was a problem hiding this comment.
Should we always check autoscoped name here, or is supposed to be limited only to cases where the suggestion is an enum constructor?
There is no harm in doing it every time we can.
Also I think this logic change should be included in possibleFunctions property documentation. It no longer typically contains only FQNs.
Added note there.
There was a problem hiding this comment.
My use case seems to work with changes in this PR. Thanks @vitvakatu
While fixing prop test in #9916, I was surprised to see a lot of basically unused checks in unit tests. With the new API, the need for them is gone.
Pull Request Description
Fixes #9635
@JaroslavTulach with this change you reproduction scenario works as it should.
dropdown.works.for.autoscope.mp4
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.