Autoscoping should not escape True and False

[4e6]

Pull Request Description

close #9765

Changelog:

• fix: do not use autoscope syntax for Boolean constructors

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[4e6]

Removed probably by mistake 931baa4#diff-351fde5aa2d3fd1c17f0af68d70d9c7ab9f959effec19078b1949d86da36502d

[JaroslavTulach]

Can we avoid hardcoding True and False? Cannot the builder detect that the name is actually re-exported from the library under the same name?

[hubertp]

Yes, this smells fishy. Hardcoded values in otherwise constant-free logic.

[4e6]

The issue was about the True and False constructors.

Cannot the builder detect that the name is actually re-exported from the library under the same name?

I'll try and see if there is enough info to implement this

[4e6]

Cannot the builder detect that the name is actually re-exported from the library under the same name?

@JaroslavTulach re-exports are computed after the suggestions are built

enso/engine/runtime/src/main/java/org/enso/interpreter/runtime/TruffleCompilerContext.java

Lines 558 to 578 in 32c3f5f

	libraryModules
	.flatMap(
	module -> {
	var sug =
	SuggestionBuilder.apply(module, getTypeHierarchy(), compiler)
	.build(module.getName(), module.getIr())
	.toVector()
	.filter(Suggestion::isGlobal);
	var exports = exportsBuilder.build(module.getName(), module.getIr());
	exportsMap.addAll(module.getName(), exports);
	return sug;
	})
	.map(
	suggestion -> {
	scala.collection.immutable.Set<String> identity = new ListSet<>();
	var reexports =
	exportsMap.get(suggestion).stream()
	.map(QualifiedName::toString)
	.reduce(identity, SetOps::incl, SetOps::union);
	return suggestion.withReexports(reexports);
	})

To make this logic work, I need to make the tag values calculation as a third step:

• build suggestions
• compute re-exports
• compute tag values

I can return to this issue after the ydoc is finished

[JaroslavTulach]

OK, feel free to integrate the "quick fix".

[JaroslavTulach]

I don't like the fact that True and False are hardcoded... but feel free to integrate the fix.