-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print pending groups in-line and include their reason, also add progress bar to the runner #9796
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7552ea4
print pending groups in-line and include their reason
radeusgd 15b7066
safer escape
radeusgd 2698836
re-introduce original ordering of tests (as it is easier to read)
radeusgd 79f7c65
remove unused method
radeusgd 6caa3fa
implement progress bar
radeusgd 362e07b
Merge branch 'refs/heads/develop' into wip/radeusgd/9534-test-pending
radeusgd 7aeecf2
run progress bar if shell is interactive
radeusgd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that
Ignore_Progress_Reporter
is used on the CI, but the coloring is still there.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 7aeecf2 I have changed it so that the progress bar is displayed if
System.console() != null
. This should be enough to avoid it running on CI or piped and better than adding yet another env var.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have inspected the runs.
Indeed before the progress was displayed (badly) on CI:
![image](https://private-user-images.githubusercontent.com/1436948/326016019-b431f590-23f3-4f1d-9a8f-c7a1a4616c8d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMTY5MjksIm5iZiI6MTczOTExNjYyOSwicGF0aCI6Ii8xNDM2OTQ4LzMyNjAxNjAxOS1iNDMxZjU5MC0yM2YzLTRmMWQtOWE4Zi1jN2ExYTQ2MTZjOGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMTU1NzA5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTg1ZGQ0NmZjZGQwOTQwOTViOTdjYjAyNmM0OTIwNjkxMzU3ZWQxZmFiNjg1YjY3MzE5OTI4MzcxOTRjYWYxNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.6HR51yVTjP4RovbLSARHu2wuU66ZE31XbNBiSuwGcJM)
But after the above commit all seems fine again:
![image](https://private-user-images.githubusercontent.com/1436948/326015971-e1ca8e7b-8eb9-477b-9a19-00f8cd8a1f96.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxMTY5MjksIm5iZiI6MTczOTExNjYyOSwicGF0aCI6Ii8xNDM2OTQ4LzMyNjAxNTk3MS1lMWNhOGU3Yi04ZWI5LTQ3N2ItOWExOS0wMGY4Y2Q4YTFmOTYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDlUMTU1NzA5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWY0NGVkMGZiODcwOWVlOWUyMzE3NzQxY2I2YmI4ZWE5NGQwZjY3MjI4ZDY4MDEyMDgxYjMwNjFjOTljYmJkNiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.efnEQbEJnPn0ukG3U9UbwRHgpztJ5EmtKduGfX1vlQk)
I think the automatic detection of console is even better than an env var.