Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Truffle API dependency from runtime-compiler project #9785

Merged
merged 16 commits into from
Apr 26, 2024
Merged

Removing Truffle API dependency from runtime-compiler project #9785

merged 16 commits into from
Apr 26, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Apr 25, 2024 •
edited
Loading

Pull Request Description

Fixes #8888 by removing dependency on Truffle API and polyglot-api from runtime-compiler project.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • All code has been tested:
    • Unit tests have been written where possible.

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 25, 2024
@JaroslavTulach JaroslavTulach self-assigned this Apr 25, 2024
hubertp
hubertp approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@hubertp hubertp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of using Object and then explicit casting. Kind of throws any static type checking out of the window.

...on/src/main/scala/org/enso/interpreter/instrument/job/DeserializeLibrarySuggestionsJob.scala Show resolved Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/TruffleCompilerContext.java Show resolved Hide resolved
@JaroslavTulach JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Apr 25, 2024
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/RuntimeSuggestions8888 branch from 42e0e5c to 3eada0b Compare April 25, 2024 12:29
@enso-bot enso-bot bot mentioned this pull request Apr 26, 2024
Closed
@JaroslavTulach JaroslavTulach changed the title Introducing runtime-suggestions module Removing Truffle API dependency from runtime-compiler project Apr 26, 2024
@JaroslavTulach JaroslavTulach force-pushed the wip/jtulach/RuntimeSuggestions8888 branch from 391c8c8 to 086bc7e Compare April 26, 2024 12:32
@JaroslavTulach JaroslavTulach added the CI: Ready to merge This PR is eligible for automatic merge label Apr 26, 2024
@mergify mergify bot merged commit c5bf238 into develop Apr 26, 2024
40 of 64 checks passed
@mergify mergify bot deleted the wip/jtulach/RuntimeSuggestions8888 branch April 26, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@radeusgd radeusgd radeusgd approved these changes

@4e6 4e6 4e6 approved these changes

@hubertp hubertp hubertp approved these changes

@jdunkerley jdunkerley Awaiting requested review from jdunkerley

@GregoryTravis GregoryTravis Awaiting requested review from GregoryTravis

@AdRiley AdRiley Awaiting requested review from AdRiley

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove org.graalvm.truffle:truffle-api dependency from runtime-compiler
5 participants
@JaroslavTulach @hubertp @4e6 @radeusgd @Akirathan