Add Decimal.min and .max
#9663
Merged
Add Decimal.min and .max
#9663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GregoryTravis
requested review from
jdunkerley,
radeusgd and
AdRiley
as code owners
radeusgd
reviewed
Apr 9, 2024
| Decimal.new "12E73" . max (Decimal.new "13E60") . should_equal (Decimal.new "12E73") | ||
| Decimal.new "12E73" . max (Decimal.new "13E80") . should_equal (Decimal.new "13E80") | ||
| Decimal.new "-12E73" . max (Decimal.new "-13E60") . should_equal (Decimal.new "-13E60") | ||
| Decimal.new "-12E73" . max (Decimal.new "-13E80") . should_equal (Decimal.new "-12E73") |
There was a problem hiding this comment.
There are no tests for cases where decimals and non-decimals are intertwined.
I think both
Decimal.new "123" . max 100 . should_equal 123
124 . max (Decimal.new "101") . should_equal 124
would be good to check.
radeusgd
reviewed
Apr 9, 2024
| Decimal.new "12" . max (Decimal.new "13") | ||
| # => Decimal.new "13" | ||
| max : Number -> Number | ||
| max self that = if self > that then self else that |
There was a problem hiding this comment.
Suggested change
| max self that = if self > that then self else that | |
| max self (that : Number) = if self > that then self else that |
It feels like we should also have the checked type ascription here - this should probably make for better widgets in the GUI (at least in future) and will aid type checking.
There was a problem hiding this comment.
Done -- actually changed to Decimal; Number was wrong.
radeusgd
reviewed
Apr 9, 2024
radeusgd
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build.