Accept small BigInteger values #9655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
4e6,
hubertp and
Akirathan
as code owners
JaroslavTulach
commented
Apr 9, 2024
| "!interop.isTime(hostObject)", | ||
| "!interop.isDate(hostObject)", | ||
| "!interop.isTimeZone(hostObject)" | ||
| }) | ||
| long hashCodeForHostObject( |
There was a problem hiding this comment.
After adding few new small java.math.BigInteger values to ValuesGenerator, this specialization started to trigger for a HostObject around java.util.List - e.g. something that should go to hasArrayElement specialization.
Adding few negative guards, but possibly the right thing is to use the SpecializationType pattern.
hubertp
approved these changes
Apr 9, 2024
jdunkerley
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #9392 by accepting more values as
isBigIntegerinEqualsSimpleNode.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides