-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GraalVM 24.0.0 #9647
Update to GraalVM 24.0.0 #9647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to update the Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove other usages of @Cached ignore
. Otherwise fine. Thank you for such a smooth upgrade.
engine/runtime/src/main/java/org/enso/interpreter/runtime/data/vector/ArraySlice.java
Show resolved
Hide resolved
@4e6 Unlike to previous GraalVM updates, updating the Dockerfile is not necessary anymore. That Dockerfile will need updating once we update JDK version, and not the maven packages. Note that this PR only updates associated Maven packages, not JDK itself. |
…alvm-24.0 # Conflicts: # tools/legal-review/engine/report-state # tools/legal-review/project-manager/report-state
Closes #9609
Pull Request Description
Update the GraalVM-related Maven packages from 23.1.2 to 24.0.0.
Important Notes
The language home search functionality in Truffle changed. It used to find the home for Enso from the class loader of
EnsoLanguage
:https://github.com/oracle/graal/blob/graal-23.1.2/truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/LanguageCache.java#L362
In 24.0.0, the language home is no longer found via class loader, but via system properties:
https://github.com/oracle/graal/blob/graal-24.0.0/truffle/src/com.oracle.truffle.polyglot/src/com/oracle/truffle/polyglot/LanguageCache.java#L353
I provided a "fix" for this by an explicit specification of the
org.graalvm.language.enso.home
system property in our launchers.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.