Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disable BackgroundCompilation in benchmarks #9646

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

Akirathan
Copy link
Member

@Akirathan Akirathan commented Apr 8, 2024

Fixes #9563 and #9470

Pull Request Description

Setting --engine.BackgroundCompilation=false causes huge regressions in the Engine benchmarks. This PR ensures that all the contexts in the benchmarks are created with BackgroundCompilation=true.

#9470 is "fixed" by increasing warmup for Table sorting stdlib benchmarks. We will monitor these to check if that was sufficient.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • All code has been tested:
    • Unit tests have been written where possible.
    • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

@Akirathan Akirathan added the CI: No changelog needed Do not require a changelog entry for this PR. label Apr 8, 2024
@Akirathan Akirathan self-assigned this Apr 8, 2024
@Akirathan Akirathan linked an issue Apr 8, 2024 that may be closed by this pull request
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, if the benchmarks get more stable.

@Akirathan Akirathan merged commit 7850312 into develop Apr 8, 2024
36 checks passed
@Akirathan Akirathan deleted the wip/akirathan/9563-benches-enable-bg-compilation branch April 8, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engine benchmark regression on 2024-03-04 stdlibs benchmark regression
3 participants