-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google analytics sample data #9571
Conversation
## ICON key | ||
Feeding this into supporting components will give sample data for that commponent. | ||
Sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if it wouldn't be better to have a separate type (e.g. Google_Sample_Data_Source
) and if a method supports the 'sample' mode, it could take credentials : Google_Credential | Google_Sample_Data_Source
clearly indicating that either is accepted.
This way, we can easily indicate in the type if the sample mode is available or not.
In the current state, it will only be seen at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. It's a fair suggestion. Can't decide if it is better or not. I think generally this will only be used in workflows that we have built as samples so it's probably unlikely that a user will actually build a workflow using it.
Think I'm going to merge this one as is for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so it's probably unlikely that a user will actually build a workflow using it.
I guess that suggests that keeping it separate may be a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK.
One idea about the API - I'm concerned if having the Sample
available in all kinds of operations we'll have in the future will be that good. But I'm not really sure if it's a problem, so please treat as a light optional suggestion - I'm not 100% convinced my suggestion is really better than the current approach.
Pull Request Description
This adds a new Google_Credential type of Sample. Which when passed to supporting components (like Google analytics) makes that component produce sample data. This can then be used to publish example workflows.
Sample data is fairly basic right now, but could be extended in the future.
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.