Equality does not swallow errors

[Akirathan]

Fixes #9283

Pull Request Description

42 == (Error.throw "foo") now correctly returns an Error rather than False

Important Notes

The error was in the wrong usage of the org.enso.interpreter.dsl.AcceptsError DSL annotation.

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

• The documentation has been updated, if necessary.
• Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
• All code follows the
  Scala,
  Java,
  and
  Rust
  style guides. In case you are using a language not listed above, follow the Rust style guide.
• All code has been tested:
  • Unit tests have been written where possible.
  • If GUI codebase was changed, the GUI was tested when built using ./run ide build.

[Akirathan]

If a builtin method does not handle DataflowError itself, it should not annotate parameters with @AcceptsError. In other words, if @AcceptsError annotation is used, there should be a specialization that handles DataflowErrors.

[radeusgd]

Could you please also remove the workaround that was added because of the bug?

It should be enough to revert this commit: 32f876d

[Akirathan]

Could you please also remove the workaround that was added because of the bug?

It should be enough to revert this commit: 32f876d

@radeusgd Reverted in 805785d

[enso-bot]

Pavel Marek reports a new STANDUP for today (2024-03-27):

Progress: - Turns out I forgot to add the --disable-private-check cmd line option to our runner.

• Add --disable-private-check runner option #9556
• Spotted enormous engine benchmark regressions at the beginning of March - Engine benchmark regression on 2024-03-04 #9563
  • Investigating
  • We should not use engine.BackgroundCompilation=false for benchmarks - Engine benchmark regression on 2024-03-04 #9563 (comment)
• Fix for subprocess hang in Subprocess does not freeze when it generates a lot of output to stdout #9550
• Continue bookclubbing - engine bench analysis It should be finished by 2024-03-28.