-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make expand_to_rows, expand_column support Rows, Tables, Column data types #9533
Conversation
35ae360
to
4e12764
Compare
distribution/lib/Standard/Table/0.0.0-dev/src/Data/Conversions/Convertible_To_Columns.enso
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
It's good to see that the Convertible_To_Rows
and its sibling allow for such easy extensibility of this feature. It's nice to see some cool idioms for abstraction in Enso settling in.
I think we may want to add one test, although I assume it may not be strictly necessary because it is tested by other paths (I think JSON already tests this codepath well).
1c8a1d0
to
28ad13c
Compare
28ad13c
to
4493b51
Compare
Pull Request Description
Make expand_to_rows work for Table and Column
Make expand_column work for Column and Row
Makes solving the book club exercise easier
Important Notes
We decided expand_column did not make sense for Table as the resulting Table of Columns would rarely be what was wanted.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
./run ide build
.