Trading shouldNotReachHere() for an abstract method #9312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
JaroslavTulach
commented
Mar 7, 2024
| @@ -90,7 +90,8 @@ Object invokeWithWarnings( | |||
| Warning[] extracted = warnings.getWarnings(warning, null, false); | |||
| return WithWarnings.wrap(EnsoContext.get(this), result, extracted); | |||
| } catch (UnsupportedMessageException e) { | |||
| throw CompilerDirectives.shouldNotReachHere(e); | |||
There was a problem hiding this comment.
UnsupportedMessageException may happen. We are calling to unknown implementation, unknown language and we cannot assume how it is implemented. As such it is safer to not panic on JVM level but propagate such state as a regular Enso interpreter panic.
eb5a030 does that for whole engine/runtime project.
JaroslavTulach
added
the
CI: No changelog needed
hubertp
approved these changes
Mar 7, 2024
Akirathan
approved these changes
Mar 7, 2024
engine/runtime/src/main/java/org/enso/interpreter/node/callable/InvokeMethodNode.java
Show resolved
Hide resolved
JaroslavTulach
added
CI: Ready to merge
|
Jaroslav Tulach reports a new STANDUP for yesterday (2024-03-07): Progress: - PR to eliminate
Next Day: 50% of work
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Avoiding
shouldNotReachHere()in favor of less fatal exceptions/constructs.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,
style guides.